vtctl: Allow ALTER VITESS_MIGRATION commands in sharded environment#9458
Merged
deepthi merged 2 commits intovitessio:mainfrom Jan 5, 2022
Merged
Conversation
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
dbussink
approved these changes
Jan 4, 2022
Member
dbussink
left a comment
dbussink
left a comment
There was a problem hiding this comment.
Nice, good to allow these as well then.
… path Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
deepthi
approved these changes
Jan 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Followup to #9303, which added support for
ALTER VITESS_MIGRATIONinvtctl ApplySchema.Unfortunately, on sharded keyspaces an internal validation fails the statement. This PR fixes the validation to allow
ALTER VITESS_MIGRATIONeven in sharded (multi-shard) environments.Related Issue(s)
Checklist