Use PRS in Vtorc for electing new primary#9409
Merged
GuptaManan100 merged 16 commits intovitessio:mainfrom Jan 6, 2022
Merged
Conversation
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
…tion is needed to not spawn incorrect failovers Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
…thout specifying a new primary Signed-off-by: Manan Gupta <manan@planetscale.com>
…replication status Signed-off-by: Manan Gupta <manan@planetscale.com>
…derlying contains interface doesn't Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Contributor
Author
|
The implementation of the |
Signed-off-by: Manan Gupta <manan@planetscale.com>
deepthi
reviewed
Jan 4, 2022
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
deepthi
approved these changes
Jan 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the implementation of
electNewPrimaryto usePlannedReparentShardinstead of having its own codepath. It also changes some checks inPlannedReparentShardto allow calling it with no new primary specified even for initialisation. No new end to end test has been added for this since there is already extensive coverage in the vtorc's tests which rely onelectNewPrimary(PlannedReparentShard) to initialise the cluster.Related Issue(s)
Checklist
Deployment Notes