CI: Simplify Changes to Explicitly Install and Configure MySQL8#9370
CI: Simplify Changes to Explicitly Install and Configure MySQL8#9370deepthi merged 2 commits intovitessio:mainfrom
Conversation
Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
changed the title
|
|
||
| - name: Get dependencies | ||
| run: | | ||
|
|
There was a problem hiding this comment.
@GuptaManan100 pointed out that this file is actually generated (see Line 1) using https://github.com/vitessio/vitess/blob/main/test/ci_workflow_gen.go.
I'm not sure what happens to other tests if we change the template that is being used by the make target to generate yaml files.
I guess you will need to try and move these changes into the template and if it breaks other tests, then maybe create a new template for mysql80?
There was a problem hiding this comment.
Yeah, will need to do something there. Running make generate_ci_workflow puts cluster_endtoend_mysql80.yml back into its original state where it breaks after the ubuntu-latest image change.
There was a problem hiding this comment.
Added support here: 9f6bd06
So now make generage_ci_workflow produces what I had previously done in the generated file.
Signed-off-by: Matt Lord <mattalord@gmail.com>
GuptaManan100
left a comment
GuptaManan100
left a comment
There was a problem hiding this comment.
LGTM!
We can even remove the ubuntu version check. Like make all the tests run on 18.04. As far as I know, we were only using 20.04 to get the mysql 8.0 pre-installed
|
|
||
| type clusterTest struct { | ||
| Name, Shard string | ||
| Name, Shard, Platform string |
There was a problem hiding this comment.
This is elegant.
Only one nit, Platform doesn't seem like the right term for database (hat is what we are changing here).
How about using Flavor since we use that elsewhere in the code base?
There was a problem hiding this comment.
I had similar thoughts, but:
- We already use Platform this way (e.g. mysql57, mariadb102) for the unit tests and the self hosted cluster e2e tests in the same file
- We already use OS, and Flavor is used for the GTID type so the Flavor is mysql56 for 5.7 and 8.0 in those contexts
I'm fine changing it to whatever though.
There was a problem hiding this comment.
alright, you've convinced me :)
If we are already using Platform, it makes sense to keep it consistent.
3 participants
Description
Limiting the new/additional work we do in the CI in order to limit the time and effort required to meet the primary objective: ensure that we deterministically install the latest MySQL 8.0 release from the official MySQL APT repo.
Related Issue(s)
Follow-up on: #9368
Caused by: actions/runner-images#4674
Checklist