Skip to content

Throttler: cleaning up legacy remote MySQL connection logic#9337

Merged
deepthi merged 8 commits intovitessio:mainfrom
planetscale:throttler-http-cleanup
Dec 8, 2021
Merged

Throttler: cleaning up legacy remote MySQL connection logic#9337
deepthi merged 8 commits intovitessio:mainfrom
planetscale:throttler-http-cleanup

Conversation

@shlomi-noach
Copy link
Contributor

@shlomi-noach shlomi-noach commented Dec 8, 2021

Description

Followup to #9334
Since #9334 is merged, the throttler no longer directly accesses MySQL on other tablets. As such, there's no longer need in:

  • A special throttler user account
  • Any user/password configuration
  • logic to open a remote connection
  • any special logic upon promotion to leader (other than generate a Tick)
    This PR cleans up all the above with minor refactoring/changes.

Related Issue(s)

#9334

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach shlomi-noach changed the title Throttler http cleanup Throttler: cleaning up legacy remote MySQL connection logic Dec 8, 2021
Copy link
Member

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🥇

Copy link
Collaborator

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@deepthi deepthi merged commit 43f2075 into vitessio:main Dec 8, 2021
@deepthi deepthi deleted the throttler-http-cleanup branch December 8, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants