Rename master to primary/source in web interface of vtorc#9229
Merged
deepthi merged 1 commit intovitessio:mainfrom Nov 15, 2021
Merged
Rename master to primary/source in web interface of vtorc#9229deepthi merged 1 commit intovitessio:mainfrom
deepthi merged 1 commit intovitessio:mainfrom
Conversation
Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100
added
Type: Bug
Component: VTOrc
GuptaManan100
requested review from
deepthi,
harshit-gangal and
shlomi-noach
Member
harshit-gangal
left a comment
harshit-gangal
left a comment
There was a problem hiding this comment.
LGTM.
It would be good to add a test for the bug fix.
Collaborator
|
Re: backport, we avoid backporting non-critical fixes because they can themselves possibly cause additional regressions. |
Collaborator
We discussed this earlier today. Since vtorc UI will be replaced by vtadmin, it is not worth creating a UI test framework for it. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As a part of the naming convention change in VtOrc, the change in the website files was missed. This caused the website to not work at all in release-12 since it didn't find the required fields and got stuck loading the initial page. This PR addresses this and renames constructs from
mastertoprimary/sourcein accordion with the remaining code-baseRelated Issue(s)
web/orchestrator/public/js#9150Checklist
Deployment Notes