[backport] Fix boolean parameter order in DropSources call for v2 flows#9178
Merged
ajm188 merged 1 commit intovitessio:release-12.0from Nov 18, 2021
Merged
[backport] Fix boolean parameter order in DropSources call for v2 flows#9178ajm188 merged 1 commit intovitessio:release-12.0from
ajm188 merged 1 commit intovitessio:release-12.0from
Conversation
ajm188
added
Type: Bug
Component: Cluster management
Component: VReplication
Backport
Fix boolean parameter order in DropSources call for v2 flows Signed-off-by: Andrew Mason <amason@slack-corp.com>
ajm188
force-pushed
the
backport-9175
branch
from
d124f2c to
dc542ad
Compare
deepthi
reviewed
Nov 10, 2021
Collaborator
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
Can you state a justification for the backport?
Contributor
Author
|
I figured we should backport because anyone using the v2 flows (which are now the default) can't use the |
deepthi
approved these changes
Nov 12, 2021
Collaborator
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
Approving the back port.
This affects migrations to vitess from existing prod systems. For any number of reasons, you might want to keep the existing system around and not drop it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR backports #9175 to the 12.0 release branch
Related Issue(s)
#9174
Checklist
Deployment Notes