Skip to content

Inclusive Naming: fix aya example and orc_test.sh #8941

Merged
deepthi merged 2 commits intovitessio:release-12.0from
planetscale:ds-aya-naming
Oct 9, 2021
Merged

Inclusive Naming: fix aya example and orc_test.sh #8941
deepthi merged 2 commits intovitessio:release-12.0from
planetscale:ds-aya-naming

Conversation

@deepthi
Copy link
Copy Markdown
Collaborator

@deepthi deepthi commented Oct 6, 2021

Description

Fix a few references in examples.

Related Issue(s)

#8618

Checklist

  • Should this PR be backported? NO
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi deepthi requested review from askdba and removed request for rohit-nayak-ps October 6, 2021 22:15
done

# set one of the replicas to primary
#vtctlclient InitShardMaster -force commerce/0 zone1-100
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be replaced with a (commented-out 😂) InitShardPrimary call?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't think it was necessary since vtorc is supposed to automatically elect a primary.

Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi deepthi merged commit ad0d816 into vitessio:release-12.0 Oct 9, 2021
@deepthi deepthi deleted the ds-aya-naming branch October 9, 2021 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants