[12.0] grpc streamexecute to set a target if tablet type is provided#8933
Merged
harshit-gangal merged 3 commits intovitessio:release-12.0from Oct 7, 2021
Merged
[12.0] grpc streamexecute to set a target if tablet type is provided#8933harshit-gangal merged 3 commits intovitessio:release-12.0from
harshit-gangal merged 3 commits intovitessio:release-12.0from
Conversation
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
added
Type: Bug
Component: Query Serving
Backport
systay
approved these changes
Oct 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The go vitess driver uses StreamExecute to execute the
stream * from <message_table>. In the grpc request if the target is not provided then it sets to <request.keyspace>@<request.tablet_type>If the request.tablet_type is not set then the default is
unknowntablet type.The fix is to not set the the default target if tablet type is not provided.
Later in the code there is check to use
default_tablet_typeof vtgate to server the query if the tablet_type is not present in the target.Related Issue(s)
stream * fromqueries #8676Checklist
Deployment Notes