Skip to content

Add restore_extra_restart_args for restore #8929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
5antelope wants to merge 1 commit into from
Closed

Add restore_extra_restart_args for restore #8929

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion go/vt/mysqlctl/backup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ import (
"strings"
"time"

"vitess.io/vitess/go/flagutil"

"context"

"vitess.io/vitess/go/mysql"
Expand Down Expand Up @@ -88,10 +90,17 @@ var (
// once before the writer blocks
backupCompressBlocks = flag.Int("backup_storage_number_blocks", 2, "if backup_storage_compress is true, backup_storage_number_blocks sets the number of blocks that can be processed, at once, before the writer blocks, during compression (default is 2). It should be equal to the number of CPUs available for compression")

// restoreExtraRestartArgs is the extra args for mysqld during restart for restore
restoreExtraRestartArgs flagutil.StringListValue

backupDuration = stats.NewGauge("backup_duration_seconds", "How long it took to complete the last backup operation (in seconds)")
restoreDuration = stats.NewGauge("restore_duration_seconds", "How long it took to complete the last restore operation (in seconds)")
)

func init() {
flag.Var(&restoreExtraRestartArgs, "restore_extra_restart_args", "comma separated list of extra mysqld args to pass in during a restart for upgrade")
}

// Backup is the main entry point for a backup:
// - uses the BackupStorage service to store a new backup
// - shuts down Mysqld during the backup
Expand Down Expand Up @@ -329,7 +338,9 @@ func Restore(ctx context.Context, params RestoreParams) (*BackupManifest, error)
// of those who can connect.
params.Logger.Infof("Restore: starting mysqld for mysql_upgrade")
// Note Start will use dba user for waiting, this is fine, it will be allowed.
err = params.Mysqld.Start(context.Background(), params.Cnf, "--skip-grant-tables", "--skip-networking")
restoreMysqldArgs := []string{"--skip-grant-tables", "--skip-networking"}
restoreMysqldArgs = append(restoreMysqldArgs, restoreExtraRestartArgs...)
err = params.Mysqld.Start(context.Background(), params.Cnf, restoreMysqldArgs...)
if err != nil {
return nil, err
}
Expand Down