Fix for padding in OrderAndCheckPartitions #8873
Merged
deepthi merged 3 commits intovitessio:mainfrom Sep 24, 2021
Merged
Conversation
added 2 commits
September 23, 2021 09:35
* We ran into some issues related to padding. This is another form of the bug fixed in here: vitessio#8296 Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
* Better description for the documentation. * For completeness, compare nil ranges in a similar a way as in the other functions Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
ajm188
reviewed
Sep 23, 2021
Contributor
ajm188
left a comment
ajm188
left a comment
There was a problem hiding this comment.
one minor copy-paste fix, then lgtm
…package naming conventions Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
ajm188
approved these changes
Sep 23, 2021
deepthi
approved these changes
Sep 24, 2021
Collaborator
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
LGTM.
Is it possible that there are other places we could be doing this wrong? Wondering if you audited the code.
ajm188
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Sep 28, 2021
Fix for padding in OrderAndCheckPartitions
33 tasks
vmogilev
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Jun 6, 2022
Fix for padding in OrderAndCheckPartitions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We ran into an issue similar to the one in #8296. While trying to switch traffic we found the following error:
This PR has three changes:
keypackage so it can check for contagious key ranges. It makes sure this function accounts for padding (in the same way as other key ranges comparison functions).OrderAndCheckPartitions.Related Issue(s)
Checklist
I don't know. Maybe?? I think this will only affect Slack. So I don't think there is a big pressure to back port this change.
Deployment Notes