Skip to content

Handle mapping of gRPC packet overflows to ERTooManyUserConnections for SELECT cases too #8853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepthi merged 1 commit into from
Oct 5, 2021
Merged

Handle mapping of gRPC packet overflows to ERTooManyUserConnections for SELECT cases too #8853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go/mysql/sql_error.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ func convertToMysqlError(err error) error {
return NewSQLError(mysqlCode.num, mysqlCode.state, err.Error())
}

var isGRPCOverflowRE = regexp.MustCompile(`.*grpc: received message larger than max \(\d+ vs. \d+\)`)
var isGRPCOverflowRE = regexp.MustCompile(`.*?grpc: (received|trying to send) message larger than max \(\d+ vs. \d+\)`)

func demuxResourceExhaustedErrors(msg string) int {
switch {
Expand Down
3 changes: 3 additions & 0 deletions go/mysql/sql_error_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ func TestDumuxResourceExhaustedErrors(t *testing.T) {
{"grpc: received message larger than max (99282 vs. 1234): trailer", ERNetPacketTooLarge},
{"grpc: received message larger than max (1234 vs. 1234)", ERNetPacketTooLarge},
{"header: grpc: received message larger than max (1234 vs. 1234)", ERNetPacketTooLarge},
{"grpc: trying to send message larger than max (18015277 vs. 16777216)", ERNetPacketTooLarge},
{"grpc: trying to send message larger than max (18015277 vs. 16777216): trailer", ERNetPacketTooLarge},
{"header: grpc: trying to send message larger than max (18015277 vs. 16777216)", ERNetPacketTooLarge},
// This should be explicitly handled by returning ERNetPacketTooLarge from the execturo directly
// and therefore shouldn't need to be teased out of another error.
{"in-memory row count exceeded allowed limit of 13", ERTooManyUserConnections},
Expand Down