Changing vtctl and vtworker remote API to also return an error.#883
Merged
alainjobart merged 2 commits intovitessio:masterfrom Jul 15, 2015
Merged
Changing vtctl and vtworker remote API to also return an error.#883alainjobart merged 2 commits intovitessio:masterfrom
alainjobart merged 2 commits intovitessio:masterfrom
Conversation
that way we don't depend on calling errFunc() *before* it actually should be called.
Member
|
LGTM |
alainjobart
added a commit
that referenced
this pull request
Jul 15, 2015
Changing vtctl and vtworker remote API to also return an error.
rsajwani
pushed a commit
to planetscale/vitess
that referenced
this pull request
Aug 1, 2022
Not closing the body leads to leaking goroutines for the reader / writer of the body. Found when validating that tests don't leak goroutines (to ensure other things get closed properly, but these cases where also found). Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
that way we don't depend on calling errFunc() before it actually should be called.
@michael-berlin @enisoc