[trace] Add logging support to opentracing plugins#8289
Merged
ajm188 merged 2 commits intovitessio:mainfrom Jun 18, 2021
Merged
[trace] Add logging support to opentracing plugins#8289ajm188 merged 2 commits intovitessio:mainfrom
ajm188 merged 2 commits intovitessio:mainfrom
Conversation
added 2 commits
June 7, 2021 19:11
…e standard logging infrastructure Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
doeg
approved these changes
Jun 9, 2021
Contributor
doeg
left a comment
There was a problem hiding this comment.
Caveat that I'm familiar with neither Jaeger nor Datadog, but this looks good to me!
ajm188
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Jul 23, 2021
[trace] Add logging support to opentracing plugins
8 tasks
33 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new flag to
package traceto initialize the opentracing tracer (either jaeger or datadog) with a logger attached. I've also introduced a struct that implements both jaeger's and datadog's logger interfaces using thego/vt/logpackage under the hood.Demo
jaeger +
JAEGER_REPORTER_LOG_SPANS=true+-tracing-enable-loggingRelated Issue(s)
Closes #8288
Checklist
Deployment Notes