Skip to content

Vttestserver docker test#8253

Merged
harshit-gangal merged 7 commits intovitessio:mainfrom
planetscale:vttestserver-docker-test
Jun 10, 2021
Merged

Vttestserver docker test#8253
harshit-gangal merged 7 commits intovitessio:mainfrom
planetscale:vttestserver-docker-test

Conversation

@GuptaManan100
Copy link
Copy Markdown
Contributor

Description

This PR adds the tests for the docker image vttestserver. The tests are not run in CI but can be run by hand manually.

Related Issue(s)

Adds tests for #8210

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Copy link
Copy Markdown

@mcronce mcronce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks real good to me

Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100 GuptaManan100 requested a review from mcronce June 9, 2021 07:55
Copy link
Copy Markdown

@mcronce mcronce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks even better ;)

Signed-off-by: GuptaManan100 <manan@planetscale.com>
@harshit-gangal harshit-gangal merged commit 791df79 into vitessio:main Jun 10, 2021
@harshit-gangal harshit-gangal deleted the vttestserver-docker-test branch June 10, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants