[vtctldserver] Migrate CellInfo, CellAlias rw RPCs#8219
Merged
ajm188 merged 4 commits intovitessio:masterfrom Jun 1, 2021
Merged
[vtctldserver] Migrate CellInfo, CellAlias rw RPCs#8219ajm188 merged 4 commits intovitessio:masterfrom
CellInfo, CellAlias rw RPCs#8219ajm188 merged 4 commits intovitessio:masterfrom
Conversation
added 4 commits
May 31, 2021 21:24
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
doeg
approved these changes
Jun 1, 2021
| } | ||
| // AddCellsAlias makes an AddCellsAlias gRPC call to a vtctld. | ||
| AddCellsAlias = &cobra.Command{ | ||
| Use: "AddCellsAlias --cells <cell1,cell2,...> [--cells <cell3> ...] <alias>", |
Contributor
There was a problem hiding this comment.
Just curious: why is the --cells flag defined twice?
Contributor
Author
There was a problem hiding this comment.
I am still unsure how to best convey this in usage strings, but pflag.StringSlice lets you do:
-x "a,b" # result: [a, b]
-x "a" -x "b" # result: [a, b]
-x "a,b" -x "c" # result: [a, b, c]
ajm188
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Jul 23, 2021
[vtctldserver] Migrate `CellInfo`, `CellAlias` rw RPCs Signed-off-by: Andrew Mason <amason@slack-corp.com>
8 tasks
33 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This migrates the read-write cell and cell alias vtctl commands to the grpc vtctldserver, namely:
AddCellInfoAddCellsAliasDeleteCellInfoDeleteCellsAliasUpdateCellInfoUpdateCellsAliasNote, there is an underlying issue in the
(*topo.Server).DeleteCellInfomethod, which I'm filing a bug for, and will link back here when I do.Example usage
Related Issue(s)
Checklist
Deployment Notes