[vtctldserver] Add guard against self-reparent, plus misc updates#8084
Merged
deepthi merged 1 commit intovitessio:masterfrom May 11, 2021
Merged
Conversation
"misc updates" such as: * s/master/primary in error messages in `ReparentTablet`. * Reimplement wrangler's `ReparentTablet` to use grpcvtctldserver's implementation under the hood. * Add a test case for the self-reparent error case. Signed-off-by: Andrew Mason <amason@slack-corp.com>
systay
added
Component: Cluster management
Type: Enhancement
deepthi
approved these changes
May 11, 2021
Collaborator
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
I see what you did 😄
LGTM
ajm188
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Jul 23, 2021
…event_self_reparent [vtctldserver] Add guard against self-reparent, plus misc updates
8 tasks
33 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
"misc updates" such as:
ReparentTablet.ReparentTabletto use grpcvtctldserver'simplementation under the hood.
Signed-off-by: Andrew Mason amason@slack-corp.com
Related Issue(s)
Fixes #8077
Checklist
Deployment Notes