Vdiff formatting improvements#8079
Merged
rafael merged 6 commits intovitessio:masterfrom May 10, 2021
Merged
Conversation
added 3 commits
May 7, 2021 14:53
…ticular it adds the following: * Adds sample rows to the diff report. This allows us to show the diff in a way that is more structured and with better formatting. * Adds a debug option that will add a Query to the diff report. This query can then later be used to check the actual vitess shards and perform further debugging. * Adds a onlyPks option to only report this information in the diffs. This is useful for cases where the data could have PII information. * Last but not least, all this info is used to provide a more comprehensive report at the end of the run. Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Member
|
@rafael , can you also create a PR to update the docs for vdiff at https://vitess.io/docs/reference/vreplication/vdiff/ (https://github.com/vitessio/website) with the new options and the sample? Thx |
…f-formatting-improvements Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Member
Author
Yes, will do! |
rafael
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Jun 8, 2021
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The following change improves how diffs are reported to users. In paticular it adds the following:
These are the kind of reports that now can be generated with these changes:
or
Checklist