Backport: Respect -disable_active_reparents in backup/restore#8063
Merged
systay merged 1 commit intovitessio:release-9.0from May 6, 2021
Merged
Backport: Respect -disable_active_reparents in backup/restore#8063systay merged 1 commit intovitessio:release-9.0from
systay merged 1 commit intovitessio:release-9.0from
Conversation
…t. Also, Begin and End Maintenance on orchestrator backup: do not restart replication if disable_active_reparents is set. Also, Begin and End Maintenance on orchestrator Signed-off-by: deepthi <deepthi@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui
requested review from
deepthi,
rohit-nayak-ps and
shlomi-noach
as code owners
shlomi-noach
approved these changes
May 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the vttablet flag -disable_active_reparents is set, then vitess should not be managing the mysql level replication.
However, it turns out that this was not being respected by backup/restore.
This PR fixes that by adding checks of the flag before restarting replication after a backup/restore. In terms of backup, this is only applicable to offline backups.
In addition, we put the vttablet into orchestrator maintenance mode during backup/restore. We require replication to be off and we do not want orchestrator noticing that it is off and enabling it again while a backup or restore is in progress.
Related Issue(s)
Backport of #7576
Checklist
Deployment Notes