vreplication: fix vreplication timing metrics#8060
Merged
systay merged 1 commit intovitessio:release-9.0from May 6, 2021
Merged
vreplication: fix vreplication timing metrics#8060systay merged 1 commit intovitessio:release-9.0from
systay merged 1 commit intovitessio:release-9.0from
Conversation
Several of the vreplication metrics were recently updated to no longer be correct. Specifically time.Now() is no longer executed when the function starts and is instead executed when the defer statement is called after the end of the function. This updates the metrics to properly execute time.Now() at the start of the functions. Signed-off-by: Dylan Visher <dvisher@figma.com>
systay
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8024
Several of the vreplication metrics were recently updated to no longer be
correct. Specifically time.Now() is no longer executed when the function
starts and is instead executed when the defer statement is called after the end
of the function.
This updates the metrics to properly execute time.Now() at the start
of the functions.
Signed-off-by: Dylan Visher dvisher@figma.com
Description
Related Issue(s)
Checklist
Deployment Notes