Add missing return on a failed GetShard call in FindAllShardsInKeyspace#7992
Merged
rafael merged 1 commit intovitessio:masterfrom May 4, 2021
Merged
Add missing return on a failed GetShard call in FindAllShardsInKeyspace#7992rafael merged 1 commit intovitessio:masterfrom
GetShard call in FindAllShardsInKeyspace#7992rafael merged 1 commit intovitessio:masterfrom
Conversation
…space` Signed-off-by: Andrew Mason <amason@slack-corp.com>
ajm188
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Jul 23, 2021
Add missing return on a failed `GetShard` call in `FindAllShardsInKeyspace`
8 tasks
33 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrew Mason amason@slack-corp.com
Description
I caught this while setting up
errcheckin our linter, and I'm glad I did!Related Issue(s)
Checklist
GetShardcall (without failing the earlierGetShardNamescall) in order to write a test case; do you have any ideas/suggestions?Deployment Notes