Online DDL: introducing ddl_strategy -singleton-context flag#7946
Merged
shlomi-noach merged 11 commits intovitessio:masterfrom Apr 26, 2021
Merged
Online DDL: introducing ddl_strategy -singleton-context flag#7946shlomi-noach merged 11 commits intovitessio:masterfrom
-singleton-context flag#7946shlomi-noach merged 11 commits intovitessio:masterfrom
Conversation
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
8 tasks
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Contributor
Author
|
tests added and looking good. |
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
systay
reviewed
Apr 26, 2021
go/vt/vttablet/onlineddl/executor.go
Outdated
| case onlineDDL.StrategySetting().IsSingleton(): | ||
| // We will reject this migration if there's any pending migration | ||
| if len(pendingUUIDs) > 0 { | ||
| return result, fmt.Errorf("singleton migration rejected: found pending migrations [%s]", strings.Join(pendingUUIDs, ", ")) |
Collaborator
There was a problem hiding this comment.
vterrors should be used, right?
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
systay
added
Component: Query Serving
Type: Enhancement
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Followup to #7785
This PR introduces
ddl_strategynow supports-singleton-contextflag.-singletonrejects a migration if there's any other pending migration-singleton-contextrejects a migration is there's any other pending migration that has a different migration context.With
-singleton-context, it is possible to submit multiple migrations which all share the same migration context. For example, the following is allowed:The above submits three migrations. All three will be accepted. For comparison, running the above with
-singletonwould accept the first migration (drop table if exists t1) and reject the other two.Related Issue(s)
Checklist
Deployment Notes
Impacted Areas in Vitess
Components that this PR will affect: