Skip to content

fix backup_xtrabackup flaky test#7928

Closed
shlomi-noach wants to merge 2 commits intovitessio:masterfrom
planetscale:flaky-cluster-endtoend-20-xtrabackup
Closed

fix backup_xtrabackup flaky test#7928
shlomi-noach wants to merge 2 commits intovitessio:masterfrom
planetscale:flaky-cluster-endtoend-20-xtrabackup

Conversation

@shlomi-noach
Copy link
Contributor

@shlomi-noach shlomi-noach commented Apr 22, 2021

Description

Looking into flaky TestXtrabackup (endtoend 20) tests.

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach shlomi-noach marked this pull request as ready for review April 22, 2021 10:53
@shlomi-noach
Copy link
Contributor Author

This works and is better than what we have right now. A future iteration will get rid of the Sleep() and will look for a formal Wait on condition.

@shlomi-noach shlomi-noach requested a review from a team April 22, 2021 10:54
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Copy link
Contributor Author

Implicitly merged via #7785

@shlomi-noach shlomi-noach deleted the flaky-cluster-endtoend-20-xtrabackup branch April 22, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant