Skip to content

backport: upgrade tests vs v9#7899

Merged
shlomi-noach merged 9 commits intovitessio:release-10.0from
planetscale:release-10.0-ci-upgrade-v9
Apr 21, 2021
Merged

backport: upgrade tests vs v9#7899
shlomi-noach merged 9 commits intovitessio:release-10.0from
planetscale:release-10.0-ci-upgrade-v9

Conversation

@shlomi-noach
Copy link
Copy Markdown
Contributor

Description

Backport of #7848, test upgrade vs. v9

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

cc @askdba @deepthi

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Copy link
Copy Markdown
Contributor Author

Currently GitHub/workflows CI has a DNS resolution issue, described in actions/runner-images#3185

I'm using this PR to also backport the patch suggested in said issue, which was proven to work well via #7847

@shlomi-noach shlomi-noach marked this pull request as draft April 20, 2021 06:44
Copy link
Copy Markdown
Contributor

@askdba askdba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@deepthi
Copy link
Copy Markdown
Collaborator

deepthi commented Apr 20, 2021

The port-range and DNS fixes need to go into unit_race.yml, local_example.yml and region_example.yml. These aren't failing on the main branch right now because there we started running them in docker.

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Copy link
Copy Markdown
Contributor Author

Added the DNS+prt range patches to aforementioned tests plus other tests I thought may be relevant.

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach shlomi-noach marked this pull request as ready for review April 21, 2021 12:11
@shlomi-noach
Copy link
Copy Markdown
Contributor Author

Ahhhh it's finally green! I'm good to merge this, keeping this open for a few more hours then merging

@shlomi-noach shlomi-noach merged commit b1f9ae9 into vitessio:release-10.0 Apr 21, 2021
@shlomi-noach shlomi-noach deleted the release-10.0-ci-upgrade-v9 branch April 21, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants