WIP Running CI workflows on Ubuntu 20.04 by shlomi-noach · Pull Request #7850 · vitessio/vitess

shlomi-noach · 2021-04-13T09:57:52Z

Description

Resubmission of #7613 (which went a bit stale). This is an attempt to see whether ubuntu-latest (20.04 at this time) reduces CI flakiness.

Checklist

Should this PR be backported?
Tests were added or are not required
Documentation was added or is not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

shlomi-noach · 2021-04-13T10:25:00Z

Percona Server 5.6 is not available in Ubuntu 20.04, so Unit Test (percona56) cannot be expected to run.

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

shlomi-noach · 2021-04-13T10:47:03Z

PASSWORD function no longer available in MySQL 8.0, so we replace it with its equivalent, CONCAT('*', UPPER(SHA1(UNHEX(SHA1('<clear-text>')))))

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

skottler

the procfs change looks good to me

shlomi-noach · 2021-04-13T14:46:36Z

At least the good news, seeing all those failed tests, is that these failures seem just flaky. I'm not sure either has to do with ubuntu 20.04

shlomi-noach · 2021-04-13T14:47:04Z

percona56 test pinned to ubuntu 18.04

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

shlomi-noach · 2021-04-18T12:37:15Z

cluster (17) and cluster (20) continue to fail.

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

shlomi-noach · 2021-05-10T04:58:30Z

keeps failing: cluster 17, cluster 20

askdba · 2021-08-17T10:46:41Z

@shlomi-noach is this still failing or ready to merge?

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

shlomi-noach · 2021-08-25T13:17:52Z

@askdba seems to pass now, but then again, looks like main already has a .Ubuntu20 flag? Not sure how it works?

GuptaManan100

LGTM! 🥇

GuptaManan100 · 2021-08-26T05:10:03Z

@shlomi-noach That was something, that I had added. It was only for 1 test so that it runs mysql-80 in the end to end tests

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

shlomi-noach · 2021-08-26T08:25:04Z

OK, do we want to always use Ubuntu 20 now for all workflows? (I'm asking because main makes that configurable, we'd need to remove that configurable code)

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

github-actions · 2022-07-19T01:39:28Z

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

Push additional commits to the associated branch.
Remove the stale label.
Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

github-actions · 2022-07-26T01:40:30Z

This PR was closed because it has been stale for 7 days with no activity.

Running CI workflows on Ubuntu 20.04

f84676f

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

shlomi-noach mentioned this pull request Apr 13, 2021

DO NOT MERGE: switch all CI workflows to run on Ubuntu 20.04 #7613

Closed

5 tasks

shlomi-noach marked this pull request as draft April 13, 2021 10:12

force install 5.7

4a05a84

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

shlomi-noach added 2 commits April 13, 2021 13:44

backwards and forward compatible PASSWORD function alternative

6cff576

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

mysql 5.7 for unit tests

2a5b43e

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

shlomi-noach added 5 commits April 13, 2021 14:35

tune up the OS: increase port range

3f25212

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

tune up the OS: increase port range

bd3671a

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

tune up the OS: increase port range

00397e1

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

tune up the OS: increase port range

746d8f1

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

percona56 runs on ubuntu 18.04

7af087a

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

skottler approved these changes Apr 13, 2021

View reviewed changes

skottler mentioned this pull request Apr 13, 2021

actions: set ephemeral port range to include more ports #7854

Closed

5 tasks

merged master, resolve conflict

2602dd4

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

shlomi-noach mentioned this pull request Apr 18, 2021

flaky onlineddl tests: reduce -online_ddl_check_interval #7847

Merged

8 tasks

askdba mentioned this pull request May 7, 2021

CI tests fail with ubuntu-20.04 #7612

Open

marge master; resolve conflicts

d2355eb

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

shlomi-noach added 2 commits August 25, 2021 10:11

merge main, resolve conflict

537bbbb

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

generated workflows

6ee68eb

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

shlomi-noach added Component: Build/CI Type: CI/Build labels Aug 25, 2021

askdba requested a review from GuptaManan100 August 26, 2021 05:02

GuptaManan100 approved these changes Aug 26, 2021

View reviewed changes

Merge branch 'main' into github-actions-ubuntu-20-04

793f956

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

gofmt

5e3383b

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

deepthi mentioned this pull request Dec 13, 2021

CI: ubuntu-latest now has MySQL 8.0.26, let us override it with latest 8.0.x #9368

Merged

3 tasks

github-actions bot added the Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. label Jul 19, 2022

github-actions bot closed this Jul 26, 2022

Conversation

shlomi-noach commented Apr 13, 2021

Description

Checklist

Deployment Notes

Impacted Areas in Vitess

Uh oh!

shlomi-noach commented Apr 13, 2021

Uh oh!

shlomi-noach commented Apr 13, 2021

Uh oh!

skottler left a comment

Choose a reason for hiding this comment

Uh oh!

shlomi-noach commented Apr 13, 2021

Uh oh!

shlomi-noach commented Apr 13, 2021

Uh oh!

shlomi-noach commented Apr 18, 2021

Uh oh!

shlomi-noach commented May 10, 2021

Uh oh!

askdba commented Aug 17, 2021

Uh oh!

shlomi-noach commented Aug 25, 2021

Uh oh!

GuptaManan100 left a comment

Choose a reason for hiding this comment

Uh oh!

GuptaManan100 commented Aug 26, 2021

Uh oh!

shlomi-noach commented Aug 26, 2021

Uh oh!

github-actions bot commented Jul 19, 2022

Uh oh!

github-actions bot commented Jul 26, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants