[vtadmin-api] Reintroduce include_non_serving_shards opt to GetSchema

[doeg]

Signed-off-by: Sara Bee 855595+doeg@users.noreply.github.com

Description

This reintroduces the include_non_serving_shards option to vtadmin-api's GetSchema endpoint. Originally, @ajm188 implemented it as part of PR #7751. It was removed in 9d5a725#diff-2e928c52fc65f3997825899db022e6259e1d9bdf5f1202fa31b83a77636ce555L648 since, at the time, we couldn't think of any use cases... and, of course, we thought of one ten days later. :') So, I am but a humble copy + paste goblin, reintroducing Andrew's existing work.

For a little more context, in the short-term, we plan to use this in vtadmin-web to calculate copy progress for vreplication streams in the copying phase. Long-term, we plan to implement this more 😎 robustly 😎 in vtadmin-api. This work is ticketed as #7813.

I'm not going to spend time constructing a local Vitess example, but I did verify that this works on my machine internally. :)

Related Issue(s)

• [vtadmin] Aggregate schema sizes #7751
• Show progress in VTAdmin for streams that are in the "copying" phase #7813

Checklist

• Should this PR be backported? No
• Tests were added or are not required
• Documentation was added or is not required

Deployment Notes

N/A

Impacted Areas in Vitess

Components that this PR will affect:

• Query Serving
• VReplication
• Cluster Management
• Build/CI
• VTAdmin

[doeg]

Yikes, that's a lot of test failures... looking.

[doeg]

Ok turns out all those test failures were flakes 😎 I re-ran 'em and everything is passing now, so this is ready for review when you get a chance! 🙇 ❤️

[ajm188]

thank you!! lg2m