Skip to content

update moby/term to fix darwin build issue#7787

Merged
systay merged 2 commits intovitessio:masterfrom
planetscale:planetscale/gedgar-update-moby-term
Apr 6, 2021
Merged

update moby/term to fix darwin build issue#7787
systay merged 2 commits intovitessio:masterfrom
planetscale:planetscale/gedgar-update-moby-term

Conversation

@gedgar
Copy link
Copy Markdown

@gedgar gedgar commented Apr 6, 2021

Description

Update moby/term to fix darwin build issue, as described in #7788

Related Issue(s)

Checklist

  • Should this PR be backported? Yes, should go into v10

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

Signed-off-by: Gary Edgar <gary@planetscale.com>
@gedgar gedgar changed the title update moby/term to fix darwin build issue on docker update moby/term to fix darwin build issue Apr 6, 2021
@deepthi deepthi requested a review from systay April 6, 2021 04:31
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Copy link
Copy Markdown
Contributor

issued go mod tidy to fix the test

@systay systay marked this pull request as ready for review April 6, 2021 14:48
@systay systay merged commit 7efa6aa into vitessio:master Apr 6, 2021
@systay systay deleted the planetscale/gedgar-update-moby-term branch April 6, 2021 14:52
@askdba askdba added this to the v11.0 milestone Apr 13, 2021
@systay systay mentioned this pull request Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue building Vitess binaries on Mac OSX

4 participants