Skip to content

[vttest] disable field caching in vttest #7768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepthi merged 3 commits into from
Apr 1, 2021
Merged

[vttest] disable field caching in vttest #7768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b45a47
disable field caching in vttestserver
harshit-gangal Mar 31, 2021
d9a8b52
added e2e test using vtcombo
harshit-gangal Mar 31, 2021
f59674b
fix linting
harshit-gangal Apr 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions go/vt/vtgate/endtoend/database_func_test.go → go/vt/vtgate/endtoend/misc_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,20 +21,30 @@ import (
"fmt"
"testing"

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"

"vitess.io/vitess/go/mysql"
)

func TestDatabaseFunc(t *testing.T) {
ctx := context.Background()
conn, err := mysql.Connect(ctx, &vtParams)
if err != nil {
t.Fatal(err)
}
require.NoError(t, err)
defer conn.Close()

exec(t, conn, "use ks")
qr := exec(t, conn, "select database()")
if got, want := fmt.Sprintf("%v", qr.Rows), `[[VARBINARY("ks")]]`; got != want {
t.Errorf("select:\n%v want\n%v", got, want)
}
require.Equal(t, `[[VARBINARY("ks")]]`, fmt.Sprintf("%v", qr.Rows))
}

func TestSysNumericPrecisionScale(t *testing.T) {
ctx := context.Background()
conn, err := mysql.Connect(ctx, &vtParams)
require.NoError(t, err)
defer conn.Close()

qr := exec(t, conn, "select numeric_precision, numeric_scale from information_schema.columns where table_schema = 'ks' and table_name = 't1'")
assert.True(t, qr.Fields[0].Type == qr.Rows[0][0].Type())
assert.True(t, qr.Fields[1].Type == qr.Rows[0][1].Type())
}
1 change: 1 addition & 0 deletions go/vt/vttest/vtprocess.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,7 @@ func VtcomboProcess(env Environment, args *Config, mysql MySQLManager) *VtProces
"-mycnf_server_id", "1",
"-mycnf_socket_file", socket,
"-normalize_queries",
"-enable_query_plan_field_caching=false",
}...)

vt.ExtraArgs = append(vt.ExtraArgs, QueryServerArgs...)
Expand Down