make sure to handle subqueries on top of subqueries#7730
Merged
systay merged 2 commits intovitessio:masterfrom Mar 25, 2021
Merged
make sure to handle subqueries on top of subqueries#7730systay merged 2 commits intovitessio:masterfrom
systay merged 2 commits intovitessio:masterfrom
Conversation
Signed-off-by: Andres Taylor <andres@planetscale.com>
Comment on lines
+169
to
+174
| select id from user where not id in (select col from music where music.user_id = 42) and id in (select col from music where music.user_id = 411) | ||
|
|
||
| 1 ks_sharded/40-80: select col from music where music.user_id = 42 limit 10001 | ||
| 2 ks_sharded/40-80: select col from music where music.user_id = 411 limit 10001 | ||
|
|
||
| ---------------------------------------------------------------------- |
Member
There was a problem hiding this comment.
this does not tell what happened to the main query, where it is executed.
I have less knowledge here. so cc: @aquarapid
Contributor
There was a problem hiding this comment.
It's not ideal, but acceptable; maybe make a note as a cleanup/enhancement item to add visibility of the top-level query?
harshit-gangal
approved these changes
Mar 23, 2021
Member
harshit-gangal
left a comment
harshit-gangal
left a comment
There was a problem hiding this comment.
Overall looks good. Hence approving it.
Signed-off-by: Andres Taylor <andres@planetscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Planning subqueries on top of subqueries was not working as expected. We broke planning of this with the 9.0 release. This is to fix this regression.
Related Issue(s)
#7682
Checklist
Yes, to the release-9.0 branchAddedImpacted Areas in Vitess
Components that this PR will affect: