-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[vtadmin] GetWorkflow(s) endpoints #7662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rohit-nayak-ps
merged 14 commits into
vitessio:master
from
tinyspeck:am_vtadmin_getworkflows
Mar 16, 2021
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b001075
Add workflow rpcs, generate types, add stubs
dab5a3e
Add request helper for parsing query params as booleans
a0c8a5d
Implement workflow endpoints
ff5531e
Add `keyspace` field to protos
5450b12
Include keyspace in final results
043cf89
Fix typo in unrelated comment
76c0a47
Implement GetWorkflows for test vtctldclient
0a00c5d
Add tests for cluster-level workflow fetchers
5be56a2
Add api-level tests for workflow fetchers
ffafe1f
Reorder functions
666d191
Move Dial calls from api to cluster, this makes more sense
cdfae90
bugfix: ParseQueryParamAsBool should check if param is non-empty, not…
2f54aa6
Update proto types to include warnings in workflow aggregations
7b9e498
Update workflows endpoints for new interface, update tests
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just moving this to the bottom of the file; it felt a bit out of place being stuck between two public functions without really being a helper function for either of them in particular