Skip to content

add support for SELECT ALL #7593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
systay merged 1 commit into from
Mar 3, 2021
Merged

add support for SELECT ALL #7593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions go/vt/sqlparser/constants.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ package sqlparser
// String constants to be used in ast.
const (
// Select.Distinct
AllStr = "all "
DistinctStr = "distinct "
StraightJoinHint = "straight_join "
SQLCalcFoundRowsStr = "sql_calc_found_rows "
Expand Down
6 changes: 6 additions & 0 deletions go/vt/sqlparser/parse_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1786,6 +1786,12 @@ var (
output: "select distinct a.* from (select 1 from dual union all select 1 from dual) as a",
}, {
input: "select `weird function name`() from t",
}, {
input: "select all* from t",
output: "select * from t",
}, {
input: "select distinct* from t",
output: "select distinct * from t",
}, {
input: "select status() from t", // should not escape function names that are keywords
}, {
Expand Down
Loading