Skip to content

orchestrator: prevent XSS attack via 'orchestrator-msg' params #7526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shlomi-noach merged 1 commit into from
Feb 23, 2021
Merged

orchestrator: prevent XSS attack via 'orchestrator-msg' params #7526

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion web/orchestrator/public/js/orchestrator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,19 @@ function isCompactDisplay() {
return ($.cookie("compact-display") == "true");
}

// origin: https://vanillajstoolkit.com/
/**
* Sanitize and encode all HTML in a user-submitted string
* https://portswigger.net/web-security/cross-site-scripting/preventing
* @param {String} str The user-submitted string
* @return {String} str The sanitized string
*/
function sanitizeHTML (str) {
return str.replace(/[^\w-_. ]/gi, function (c) {
return '&#' + c.charCodeAt(0) + ';';
});
}

function anonymizeInstanceId(instanceId) {
var tokens = instanceId.split("__");
return "instance-" + md5(tokens[1]).substring(0, 4) + ":" + tokens[2];
Expand Down Expand Up @@ -1133,7 +1146,7 @@ $(document).ready(function() {
$("[data-nav-page=user-id]").css('display', 'inline-block');
$("[data-nav-page=user-id] a").html(" " + getUserId());
}
var orchestratorMsg = getParameterByName("orchestrator-msg")
var orchestratorMsg = sanitizeHTML(getParameterByName("orchestrator-msg"))
if (orchestratorMsg) {
addInfo(orchestratorMsg)

Expand Down