docker vitess/vtctlclient: Install curl#7469
Closed
jmoldow wants to merge 1 commit intovitessio:release-9.0from
Closed
docker vitess/vtctlclient: Install curl#7469jmoldow wants to merge 1 commit intovitessio:release-9.0from
jmoldow wants to merge 1 commit intovitessio:release-9.0from
Conversation
Install curl into the docker image vitess/vtctlclient. That way,
for clients using this container, not only can they interact
with vtctld via vtctlclient, but they can also interact with
vtctld and other Vitess components via their HTTP APIs, and can
also interact with the Kubernetes API server over HTTP.
When tested with Docker Desktop for Mac, Docker version 20.10.2,
using the command
docker build --compress -f Dockerfile -t "vitess/vtctlclient:latest" .
the original Dockerfile generates an artifact that is 94.4MB
(according to docker image ls), whereas the new Dockerfile
generates a 102MB image, about an 8% increase in the image's
size.
Backport of pull request vitessio#7466.
Signed-off-by: Jordan Moldow <jmoldow@alum.mit.edu>
Contributor
Author
|
Before this merged to HEAD, https://hub.docker.com/r/vitess/vtctlclient/tags?page=1&ordering=last_updated&name=latest showed Compressed Size as 36.24 MB. After this merged, it showed Compressed Size as 37.85 MB. A 4.4% / 1.61 MB increase in Compressed Size. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of pull request #7466 for release-9.0.
Install curl into the docker image vitess/vtctlclient. That way,
for clients using this container, not only can they interact
with vtctld via vtctlclient, but they can also interact with
vtctld and other Vitess components via their HTTP APIs, and can
also interact with the Kubernetes API server over HTTP.
Signed-off-by: Jordan Moldow jmoldow@alum.mit.edu
Checklist
Deployment Notes
When tested with Docker Desktop for Mac, Docker version 20.10.2,
using the command
the original Dockerfile generates an artifact that is 94.4MB
(according to docker image ls), whereas the new Dockerfile
generates a 102MB image, about an 8% increase in the image's
size.
Before this merged to HEAD, https://hub.docker.com/r/vitess/vtctlclient/tags?page=1&ordering=last_updated&name=latest showed Compressed Size as 36.24 MB.
After this merged, it showed Compressed Size as 37.85 MB.
A 4.4% / 1.61 MB increase in Compressed Size.
Impacted Areas in Vitess
Components that this PR will affect:
vitess/vtctlclient