Add vtadmin-web build flag for configuring fetch credentials#7413
Closed
doeg wants to merge 0 commit intovitessio:masterfrom
Closed
Add vtadmin-web build flag for configuring fetch credentials#7413doeg wants to merge 0 commit intovitessio:masterfrom
doeg wants to merge 0 commit intovitessio:masterfrom
Conversation
bc8eec1 to
002b800
Compare
Contributor
Author
|
Huh... closing the pull request was unexpected. 🤔 I can't seem to re-open this PR against the same (downstream) branch, because... git fork reasons? I'll open a new one. Sorry about that! I believe what happened is:
...so, nothing see here. 🙈 |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sara Bee 855595+doeg@users.noreply.github.com
Description
As the title says, this adds a build flag for vtadmin-web to configure the fetch
credentialsproperty when making requests against vtadmin-api. This is useful for VTAdmin deployments that use cookie-based authentication.Related Issue(s)
N/A
Checklist
Deployment Notes
N/A
Impacted Areas in Vitess
Components that this PR will affect: