Skip to content

use provided xtrabackup_root_path to find xbstream #7359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepthi merged 1 commit into from
Jan 25, 2021
Merged

use provided xtrabackup_root_path to find xbstream #7359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions go/vt/mysqlctl/xtrabackupengine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ type XtrabackupEngine struct {

var (
// path where backup engine program is located
xtrabackupEnginePath = flag.String("xtrabackup_root_path", "", "directory location of the xtrabackup executable, e.g., /usr/bin")
xtrabackupEnginePath = flag.String("xtrabackup_root_path", "", "directory location of the xtrabackup and xbstream executables, e.g., /usr/bin")
// flags to pass through to backup phase
xtrabackupBackupFlags = flag.String("xtrabackup_backup_flags", "", "flags to pass to backup command. These should be space separated and will be added to the end of the command")
// flags to pass through to prepare phase of restore
Expand Down Expand Up @@ -580,7 +580,7 @@ func (be *XtrabackupEngine) extractFiles(ctx context.Context, logger logutil.Log

case xbstream:
// now extract the files by running xbstream
xbstreamProgram := xbstream
xbstreamProgram := path.Join(*xtrabackupEnginePath, xbstream)
flagsToExec := []string{"-C", tempDir, "-xv"}
if *xbstreamRestoreFlags != "" {
flagsToExec = append(flagsToExec, strings.Fields(*xbstreamRestoreFlags)...)
Expand Down