V2 Workflow Start: wait for streams to start and report errors if any while starting a workflow#7248
Merged
rohit-nayak-ps merged 2 commits intovitessio:masterfrom Jan 5, 2021
Conversation
… start within timeout, improve Show output Signed-off-by: Rohit Nayak <rohit@planetscale.com>
rohit-nayak-ps
force-pushed
the
rn-wait-for-workflow-start
branch
from
0bc4b4c to
afad5c9
Compare
rohit-nayak-ps
requested review from
ajm188,
deepthi,
doeg and
sougou
as code owners
sougou
approved these changes
Jan 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rohit Nayak rohit@planetscale.com
Description
When a MoveTables or Reshard Start is invoked:
Note that the workflow itself is not aborted. This just tells the user that there are possible issues and they need to fix it and then possibly restart the streams using the Workflow command or VExec/VReplicationExec if any custom repair is needed.
Related Issue(s)
#7071
Checklist
Impacted Areas in Vitess
Components that this PR will affect: