[vtctldclient] vtctldclient generator#7238
Merged
deepthi merged 11 commits intovitessio:masterfrom Jan 5, 2021
Merged
Conversation
added 8 commits
December 17, 2020 20:50
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
doeg
approved these changes
Jan 3, 2021
Contributor
doeg
left a comment
doeg
left a comment
There was a problem hiding this comment.
This is so cool!!! Magical, even. (In a good way!) Thank you for doing this!
I pulled your branch and re-generated client_gen.go and it looks good/worked great. (The automatic VS Code integration is so nice, too!)
My only suggestion would be that maybe we could/should add a Makefile target, but I leave that up to you. :)
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Contributor
Author
|
I was just thinking about how I should have added a Makefile target. Good call. |
Signed-off-by: Andrew Mason <amason@slack-corp.com>
doeg
reviewed
Jan 3, 2021
| @@ -0,0 +1,19 @@ | |||
| # Copyright 2020 The Vitess Authors. | |||
Contributor
There was a problem hiding this comment.
Oh... right, it's 2021 now. 😭 Haha. I guess this applies to all the files in this branch.
Signed-off-by: Andrew Mason <amason@slack-corp.com>
ajm188
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Jan 10, 2021
…ator [vtctldclient] vtctldclient generator
This was referenced Jan 10, 2021
setassociative
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Mar 11, 2021
…ator [vtctldclient] vtctldclient generator
ajm188
added
Component: Build/CI
Type: Enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a code generator to produce the boilerplate "if underlying connection is nil, return closed; otherwise, call underlying method" for every unary RPC in the vtctld client. It does not handle streaming RPCs (yet) because we do not need streaming RPCs (yet)
Related Issue(s)
Checklist
Deployment Notes
Impacted Areas in Vitess
Components that this PR will affect: