make docker_local: fix missing mysql_server package#7213
Merged
shlomi-noach merged 3 commits intovitessio:masterfrom Jan 4, 2021
Merged
make docker_local: fix missing mysql_server package#7213shlomi-noach merged 3 commits intovitessio:masterfrom
shlomi-noach merged 3 commits intovitessio:masterfrom
Conversation
We use docker/lite/install_dependencies.sh to install mysql57 server and client Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
askdba
approved these changes
Dec 22, 2020
Contributor
There was a problem hiding this comment.
LGTM
--------------
mysql Ver 14.14 Distrib 5.7.31, for Linux (x86_64) using EditLine wrapper
Connection id: 1
Current database: commerce
Current user: vt_app@localhost
SSL: Not in use
Current pager: stdout
Using outfile: ''
Using delimiter: ;
Server version: 5.7.9-Vitess MySQL Community Server (GPL)
Protocol version: 10
Connection: 127.0.0.1 via TCP/IP
Server characterset: utf8
Db characterset: utf8
Client characterset: utf8
Conn. characterset: utf8
TCP port: 15306
--------------```
…ysql-server Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Contributor
Author
|
Waiting a few more days before merging since Holidays are slow for reviews. |
…ysql-server Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Contributor
|
Thank you so much for fixing this! 🎉 |
7 tasks
Contributor
Author
|
Self reminder to merge this on Wednesday since everyone was out for so long. |
Contributor
If you merge it tomorrow it'll make it to v9.0.RC1 |
Contributor
Author
|
OK fine 😂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We use
docker/lite/install_dependencies.shto install mysql57 server and clientRelated Issue(s)
An internal discussion leading to the finding that
make docker_localis broken:Checklist
Impacted Areas in Vitess
Components that this PR will affect:
cc @askdba