Add option to GetSchema to only send the row count and data length over the wire#6985
Merged
deepthi merged 5 commits intovitessio:masterfrom Nov 29, 2020
Merged
Conversation
…er the wire Signed-off-by: Andrew Mason <amason@slack-corp.com>
Contributor
Author
|
A comment from @ameetkotian:
I think for now I'm just going to make the help text for |
Signed-off-by: Andrew Mason <amason@slack-corp.com>
deepthi
reviewed
Nov 3, 2020
Collaborator
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
The change looks fine, but I'm debating whether you should be adding a test case. It will have to be an endtoend test, I think.
@vitessio/ps-vitess any opinions?
added 3 commits
November 27, 2020 11:09
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
ajm188
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Dec 1, 2020
…er the wire (vitessio#6985) * Add option to GetSchema to only send the row count and data length over the wire Signed-off-by: Andrew Mason <amason@slack-corp.com> * Update help text to clarify behavior Signed-off-by: Andrew Mason <amason@slack-corp.com> * Add endtoend test for vtctl GetSchema Signed-off-by: Andrew Mason <amason@slack-corp.com> * Alias the proto imports Signed-off-by: Andrew Mason <amason@slack-corp.com> * Format imports to match vtctl.go Signed-off-by: Andrew Mason <amason@slack-corp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you are attempting to get aggregate table sizes across a keyspace, this requires one call to
GetSchemaper shard, which result in the caller to vtctl needing tojson2.Unmarshalthe same info (create table statement, column info) N times, when we know it's not going to change. This flag will allow a user to make oneGetSchemacall to get the schema, and then N-1GetSchema -table_sizes_onlycalls for the rest of the shards, and results in much less data transfer and much faster (3-4x faster by some metrics I took) response times.Closes #6987