INFORMATION_SCHEMA.TABLE_SCHEMA comparison with dynamic value bugfix#6881
Merged
harshit-gangal merged 1 commit intovitessio:release-8.0from Oct 15, 2020
Merged
INFORMATION_SCHEMA.TABLE_SCHEMA comparison with dynamic value bugfix#6881harshit-gangal merged 1 commit intovitessio:release-8.0from
harshit-gangal merged 1 commit intovitessio:release-8.0from
Conversation
Signed-off-by: Andres Taylor <andres@planetscale.com>
Collaborator
Author
|
I think it should go into master as well. Even after unnesting (the first fix for this issue) we could encounter an expression we can’t handle in the |
harshit-gangal
approved these changes
Oct 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we encounter a comparison with
table_schemain theWHEREclause of an information_schema query, we extract the other side of the comparison and turn it into anevalengineexpression. These expressions can be evaluated on the vtgate, and Vitess uses this information to figure out where it needs to send the query.The issue here is when Vitess fails to transform the expression from an AST expression to a
evalengineexpression.Instead of failing the query, we should just not do that particular rewrite
Fixes #6827