Flaky test: attempt to fix TestConnection in go/test/endtoend/messaging#6879
Merged
deepthi merged 1 commit intovitessio:masterfrom Oct 14, 2020
Merged
Conversation
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
deepthi
approved these changes
Oct 14, 2020
Collaborator
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
Let's merge this since tests are passing. We may need to revisit if it fails again.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seems to be an intrinsic race in the message manager's TestConnection test due to the goroutine in stream.MessageStream. Added sleeps before validations to see if that will fix the flakiness.
Signed-off-by: Rohit Nayak rohit@planetscale.com