healthcheck: should receive healthcheck updates from all tablets in cells_to_watch#6852
Merged
deepthi merged 1 commit intovitessio:masterfrom Oct 11, 2020
Merged
Conversation
…ells_to_watch Signed-off-by: deepthi <deepthi@planetscale.com>
deepthi
force-pushed
the
ds-hc-cross-cell
branch
from
0491b39 to
a14a26b
Compare
sougou
approved these changes
Oct 10, 2020
This was referenced Oct 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Healthcheck was incorrectly excluding non-local cell tablets. This fix ensures that healthcheck will connect to and monitor all tablets in
cells_to_watch. However, only tablets that are MASTER/local cell/same cell alias will be stored in the list of healthy tablets.Fixes #6846
Testing:
Signed-off-by: deepthi deepthi@planetscale.com