Skip to content

Fix and clarify some help options #6817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepthi merged 1 commit into from
Oct 5, 2020
Merged

Fix and clarify some help options #6817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions go/vt/servenv/grpc_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,13 @@ var (
GRPCPort = flag.Int("grpc_port", 0, "Port to listen on for gRPC calls")

// GRPCCert is the cert to use if TLS is enabled
GRPCCert = flag.String("grpc_cert", "", "certificate to use, requires grpc_key, enables TLS")
GRPCCert = flag.String("grpc_cert", "", "server certificate to use for gRPC connections, requires grpc_key, enables TLS")

// GRPCKey is the key to use if TLS is enabled
GRPCKey = flag.String("grpc_key", "", "key to use, requires grpc_cert, enables TLS")
GRPCKey = flag.String("grpc_key", "", "server private key to use for gRPC connections, requires grpc_cert, enables TLS")

// GRPCCA is the CA to use if TLS is enabled
GRPCCA = flag.String("grpc_ca", "", "ca to use, requires TLS, and enforces client cert check")
GRPCCA = flag.String("grpc_ca", "", "server CA to use for gRPC connections, requires TLS, and enforces client certificate check")

// GRPCAuth which auth plugin to use (at the moment now only static is supported)
GRPCAuth = flag.String("grpc_auth_mode", "", "Which auth plugin implementation to use (eg: static)")
Expand Down
2 changes: 1 addition & 1 deletion go/vt/vtctl/vtctl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2954,7 +2954,7 @@ func commandWorkflow(ctx context.Context, wr *wrangler.Wrangler, subFlags *flag.
return err
}
if subFlags.NArg() != 2 {
return fmt.Errorf("usage: Workflow --dry-run keyspace.workflow start/stop/delete/list/list-all")
return fmt.Errorf("usage: Workflow --dry-run keyspace.workflow start/stop/delete/list/listall")
}
keyspace := subFlags.Arg(0)
action := strings.ToLower(subFlags.Arg(1))
Expand Down