tm: change how SetReadOnly is called to avoid errors from externally managed tablets#6786
Merged
sougou merged 1 commit intovitessio:masterfrom Sep 25, 2020
Merged
Conversation
…managed tablets Signed-off-by: deepthi <deepthi@planetscale.com>
deepthi
commented
Sep 24, 2020
| vtrpcpb "vitess.io/vitess/go/vt/proto/vtrpc" | ||
| ) | ||
|
|
||
| // DBAction is used to tell ChangeTabletType whether to call SetReadOnly on change to |
Collaborator
Author
There was a problem hiding this comment.
I debated not exporting this enum. However, since it is a function argument to tmState.ChangeTabletType I felt that it must be exported.
sougou
approved these changes
Sep 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #6762 we changed ChangeTabletType to also set read-write on MASTER instances. However, this should not be done when dealing with externally managed tablets because it will invariably fail and could cause the whole action to fail.
This PR makes it optional so that only active cluster management functions attempt to change the read_only property of the underlying DB.
Signed-off-by: deepthi deepthi@planetscale.com