Add flags to allow PITR binlog client TLS support#6775
Merged
deepthi merged 6 commits intovitessio:masterfrom Sep 28, 2020
Merged
Add flags to allow PITR binlog client TLS support#6775deepthi merged 6 commits intovitessio:masterfrom
deepthi merged 6 commits intovitessio:masterfrom
Conversation
Fix bug where password was never passed. Signed-off-by: Jacques Grove <aquarapid@gmail.com>
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
aquarapid
force-pushed
the
jg_binlog_tls
branch
from
1615d7e to
db72799
Compare
Contributor
Author
|
I cannot easily modify the endtoend tests to test the TLS support; they need to be changed to (also) pull binlogs from an upstream mysql server (since ripple does not support serving via TLS). This will take some time; we can review the rest in the meanwhile. |
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
Contributor
Author
|
I have added an e2e test for this (TestTLSPITRRecovery). It has a few issues:
I am not planning to fix these issues in this PR. |
Run TLS PiTR test in its own workflow "shard" Signed-off-by: Jacques Grove <aquarapid@gmail.com>
aquarapid
force-pushed
the
jg_binlog_tls
branch
from
50509a0 to
fdaaf1e
Compare
Collaborator
|
@arindamnayak this looked fine to me, but can you please take a look also? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug where password was never passed.
Signed-off-by: Jacques Grove aquarapid@gmail.com