Refactor: Cleanup Noisy Workflow Logging#6744
Merged
sougou merged 2 commits intovitessio:masterfrom Sep 22, 2020
Merged
Conversation
…vel so direct Wrangler method use is less noisy as well. Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
deepthi
reviewed
Sep 21, 2020
| logger := logutil.NewMemoryLogger() | ||
| wr := New(logger, env.topoServ, env.tmc) | ||
|
|
||
| _, err := wr.ShowWorkflow(ctx, workflow, keyspace) |
Collaborator
There was a problem hiding this comment.
It will be better to continue to call this but assert on the returned result
Contributor
Author
There was a problem hiding this comment.
The point of this test though is to check the logger output, which will only exist if we call one level up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up noisy logging related to workflow methods, and moves printing logic up a level so that direct Wrangler method calls aren't printing output intended purely for vtctl command use from a console.