Skip to content

upstream s3 ListBackups bug fix for vtbackup_cleaner#6732

Merged
deepthi merged 1 commit intovitessio:masterfrom
planetscale:yz-s3-ListBackups-bug
Sep 21, 2020
Merged

upstream s3 ListBackups bug fix for vtbackup_cleaner#6732
deepthi merged 1 commit intovitessio:masterfrom
planetscale:yz-s3-ListBackups-bug

Conversation

@y00j
Copy link
Copy Markdown
Contributor

@y00j y00j commented Sep 16, 2020 •
edited
Loading

Updates the s3 ListAllBackups() function to to work from the root directory

Signed-off-by: Yujie Zhu yujiezhu718@gmail.com

@y00j y00j changed the title s3 bug fix upstream s3 ListBackups bug fix for vtbackup_cleaner Sep 16, 2020
@y00j y00j marked this pull request as ready for review September 16, 2020 21:11
@y00j y00j requested a review from sougou as a code owner September 16, 2020 21:11
@y00j y00j marked this pull request as draft September 16, 2020 21:11
@y00j y00j marked this pull request as ready for review September 18, 2020 05:07
deepthi
deepthi reviewed Sep 18, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

welcome to vitess @y00j!
Can you squash all the commits into one? By default we don't squash-merge in vitess.
Did you check whether any of the other backup storage implementations have the same problem? We should fix them also if needed. There are 3 others: file, gcs, ceph.

@y00j
fix s3 ListAllBackups() to list backups from the root directory
2123ea6 
Signed-off-by: Yujie Zhu <yujiezhu718@gmail.com>
@y00j y00j force-pushed the yz-s3-ListBackups-bug branch from d10ffcd to 2123ea6 Compare September 18, 2020 19:56
@y00j
Copy link
Copy Markdown
Contributor Author

y00j commented Sep 18, 2020 •
edited
Loading

welcome to vitess @y00j!
Can you squash all the commits into one? By default we don't squash-merge in vitess.
Did you check whether any of the other backup storage implementations have the same problem? We should fix them also if needed. There are 3 others: file, gcs, ceph.

Thanks @deepthi ! So I squashed all of the commits. I do have plans to check and fix the other backups implementations but I was hoping to do so in another PR. The first pass for vtbackup_cleaner was to deploy it to staging with only the ability to clean backups in s3, so this the only upstream change needed in Vitess. After functionality with s3 has been validated, we would then do the other backup implementations.

@y00j y00j requested a review from deepthi September 18, 2020 21:20
@deepthi deepthi merged commit 4fa527e into vitessio:master Sep 21, 2020
@deepthi deepthi deleted the yz-s3-ListBackups-bug branch September 21, 2020 02:44
@askdba askdba added this to the v8.0 milestone Oct 6, 2020
@deepthi deepthi mentioned this pull request Oct 14, 2020
Merged
@setassociative setassociative mentioned this pull request Mar 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sougou sougou Awaiting requested review from sougou

1 more reviewer

@deepthi deepthi deepthi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@y00j @deepthi @askdba