Merged
Conversation
The sharding tests were expecting an exact number of queries and transactions to be processed by vreplication. But this is not as deterministic as it used to be. All these tests are already verifying the target using SplitDiff, which is the more reliable way to verify correctness. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Contributor
Author
|
I've also changed vtctlclient's ExecuteCommand to always capture and print the output. |
deepthi
approved these changes
Sep 15, 2020
Collaborator
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
Another PR where we fix things by deleting code 😃
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sharding tests were expecting an exact number of queries and
transactions to be processed by vreplication. But this is not
as deterministic as it used to be. All these tests are already
verifying the target using SplitDiff, which is the more reliable
way to verify correctness.
Signed-off-by: Sugu Sougoumarane ssougou@gmail.com