Skip to content

Fix reparent tests which fail with tracker on#6711

Closed
rohit-nayak-ps wants to merge 6 commits intovitessio:masterfrom
planetscale:rn-tracker-should-not-use-dba-privs
Closed

Fix reparent tests which fail with tracker on#6711
rohit-nayak-ps wants to merge 6 commits intovitessio:masterfrom
planetscale:rn-tracker-should-not-use-dba-privs

Conversation

@rohit-nayak-ps
Copy link
Copy Markdown
Member

Previously vreplication (and hence the schema tracker) was using dba privileges. This causes an issue during reparenting when the tracker continues to write to the schema_version table of the (readonly) replica due to the dba privileges causing errant gtids.

Signed-off-by: Rohit Nayak rohit@planetscale.com

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
…er on

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
…sing the issue

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
…hers with schema tracker on

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps
Copy link
Copy Markdown
Member Author

@deepthi after skipping a couple of tests the test which used to fail earlier with the tracker on is working. The changing of dbuser to allprivs from dba doesn't really seem to matter though I have left it in since we want to do it anyway.

There seems to be some leakage from the two tests I skipped. If I enable TestMasterToSpareStateChangeImpossible then TestReparentNoChoiceDownMaster fails with the tracker on. If TestReparentGracefulRangeBased is enabled then TestReparentNoChoiceDownMaster fails earlier.

Is this dependence of tests on others by design?

@deepthi
Copy link
Copy Markdown
Collaborator

deepthi commented Sep 14, 2020

@deepthi after skipping a couple of tests the test which used to fail earlier with the tracker on is working. The changing of dbuser to allprivs from dba doesn't really seem to matter though I have left it in since we want to do it anyway.

There seems to be some leakage from the two tests I skipped. If I enable TestMasterToSpareStateChangeImpossible then TestReparentNoChoiceDownMaster fails with the tracker on. If TestReparentGracefulRangeBased is enabled then TestReparentNoChoiceDownMaster fails earlier.

Is this dependence of tests on others by design?

Any dependency is not by design. Not sure why enabling one test fails the next one because each test cleans up the tablets when it is done. cluster teardown should bring down mysql as well.

@rohit-nayak-ps rohit-nayak-ps changed the title Change vreplication db user to allprivs Fix reparent tests which fail with tracker on Sep 14, 2020
@rohit-nayak-ps
Copy link
Copy Markdown
Member Author

Closed. Real fix is in #6726

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants