delete row using consistent lookup vindex in where clause#6700
Merged
harshit-gangal merged 6 commits intovitessio:masterfrom Sep 14, 2020
Merged
delete row using consistent lookup vindex in where clause#6700harshit-gangal merged 6 commits intovitessio:masterfrom
harshit-gangal merged 6 commits intovitessio:masterfrom
Conversation
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
changed the title
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
systay
approved these changes
Sep 14, 2020
Signed-off-by: Andres Taylor <andres@planetscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the recent change to consistent lookup to lock lookup row on vindex map for DML queries in transaction.
It created a regression for delete using vindex lookup as the row locking happens using pre shard session and delete of vindex happens through post shard session.
This PR sees the intent of the Vindex Map and if it is Delete query then it uses post shard session for vindex row lock.
Fixes: #6698