Skip to content

restore: checkNoDB should not require tables to be present #6695

Merged
deepthi merged 3 commits intovitessio:masterfrom
planetscale:ds-check-no-db
Sep 12, 2020
Merged

restore: checkNoDB should not require tables to be present #6695
deepthi merged 3 commits intovitessio:masterfrom
planetscale:ds-check-no-db

Conversation

@deepthi
Copy link
Copy Markdown
Collaborator

@deepthi deepthi commented Sep 10, 2020

When the desired database is present, we should not check for the existence of tables.
The presence of the database is sufficient to tell us that the instance has been initialized and hence should not be restored from backup.

Signed-off-by: deepthi deepthi@planetscale.com

@deepthi deepthi requested a review from sougou as a code owner September 10, 2020 19:07
@deepthi deepthi requested a review from enisoc September 10, 2020 19:07
…esired database is present

Signed-off-by: deepthi <deepthi@planetscale.com>
Copy link
Copy Markdown
Member

@enisoc enisoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: deepthi <deepthi@planetscale.com>
…est, print

command output on failure

Signed-off-by: deepthi <deepthi@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants